[mkwkw] WEEK 01 Solutions #1677
Merged
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Jul 21, 2025
There was a problem hiding this comment.
map에 저장해둔 key, value 중 key값 만을 사용하고 계신것 같아서, set을 사용해도 괜찮지 않을까 싶습니다!
jongwanra
reviewed
Jul 27, 2025
| appearance.put(nums[i], true); | ||
| appearance.add(nums[i]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Set을 활용한 접근 방식은 굉장히 좋은 것 같습니다. 고생하셨습니다!
위 부분에는 Early Return을 적용한다면, 더 가독성이 높아지지 않을까 생각이 들어 참고차 자료 공유드립니다🙏
https://thearchivelog.dev/article/are-early-returns-any-good/
|
고생하셨습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!